Made it possible to update a single config#1981
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Enables API v2 to correctly update a single config record by routing single-object PATCH updates through the same config-update utility logic used for bulk updates, addressing issue #1980.
Changes:
- Added
ConfigUtils::updateSingleConfig()and refactoredupdateConfigs()to reuse it. - Overrode
ConfigAPI::updateObject()so single PATCH operations useConfigUtils::updateSingleConfig().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/inc/utils/ConfigUtils.php | Introduces single-config update helper and reuses it for bulk updates. |
| src/inc/apiv2/model/ConfigAPI.php | Routes single-object PATCH updates through ConfigUtils to apply special config handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
s3inlc
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1980